Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting of page title from Form/Register block and add title to customer_account_create layout #21503

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Remove setting of page title from Form/Register block and add title to customer_account_create layout #21503

merged 1 commit into from
Mar 8, 2019

Conversation

mfickers
Copy link
Contributor

Description

The Customer Registration Form Block Magento\Customer\Block\Form\Register sets the page title. If this block is included on another page, the title might be overwritten with "Create New Customer Account". I removed this behaviour from the block and instead set the page title in the layout of Customer Registration Page.

This fix is analog to the one in this pull request.

Manual testing scenarios

  1. Go to Customer Account Registration Page. The title of the page should be equal to "Create New Customer Account"
  2. Insert Magento\Customer\Block\Form\Register Block into a page. The title of that page should not be overridden by string "Create New Customer Account"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mfickers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mfickers mfickers changed the title Remove setting of page title from Form/Register block and add title to account customer_account_create layout Remove setting of page title from Form/Register block and add title to customer_account_create layout Feb 28, 2019
@magento-engcom-team magento-engcom-team added Partner: Basecom partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2019
@VladimirZaets VladimirZaets self-assigned this Feb 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4402 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 4, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 4, 2019
@magento-engcom-team magento-engcom-team merged commit e2a58eb into magento:2.3-develop Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @mfickers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 8, 2019
@sidolov
ENGCOM-4402: Remove setting of page title from Form/Register block an…
3c26454 
…d add title to customer_account_create layout #21503
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Area: Frontend Component: Customer Partner: Basecom partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@mfickers @magento-engcom-team @VasylShvorak @VladimirZaets @sidolov @nmalevanec